Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the scroll to top button overlap for small devices #909

Merged
merged 4 commits into from
May 27, 2024
Merged

Fixed the scroll to top button overlap for small devices #909

merged 4 commits into from
May 27, 2024

Conversation

kapilG0
Copy link
Contributor

@kapilG0 kapilG0 commented May 27, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #780

Description👨‍💻

Fix the scroll to top button overlap for small devices

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

I ran for mobile, ipad ,desktop mode

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

@netlify Netlify
Copy link

netlify bot commented May 27, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 1391392
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6654d08eb01b1f0008224b62
😎 Deploy Preview https://deploy-preview-909--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed May 27, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kapilG0, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@kapilG0 kapilG0 mentioned this pull request May 27, 2024
Closed
7 tasks
@Rakesh9100
Copy link
Owner

Make the changes only for the small devices and not for large ones @kapilG0

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 27, 2024

Make the changes only for the small devices and not for large ones @kapilG0

Ok thank you for your feedback let me check

@Rakesh9100 Rakesh9100 changed the title Fix the scroll to top button overlap for small devices Fixed the scroll to top button overlap for small devices May 27, 2024
@Rakesh9100 Rakesh9100 merged commit 44ced19 into Rakesh9100:main May 27, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @kapilG0

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@kapilG0 kapilG0

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the scroll to top button overlap for small devices
2 participants
@kapilG0 @Rakesh9100